src/server-shutdown.ts (1)

9-17: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Consider adding a drain timeout for production resilience.

If a client holds an HTTP connection open indefinitely, httpClosed never resolves and shutdownHttpServer hangs forever. A configurable timeout with httpServer.closeAllConnections() (Node 18.2+) as a fallback would bound shutdown latency. This is a design trade-off, not a defect — flagging for awareness.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/server-shutdown.ts` around lines 9 - 17, Add a configurable drain timeout
around the httpClosed wait in shutdownHttpServer, and when it expires invoke
httpServer.closeAllConnections() before completing shutdown. Preserve normal
graceful closure when connections drain within the timeout, and use the existing
HTTP server lifecycle symbols rather than changing closeApplication.

src/cli.ts (1)

232-246: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Extract shared shutdown handler to avoid duplication with server.ts.

The shuttingDown guard, shutdown(), handleShutdown(), and process.once pattern is identical to server.ts:1845-1860. A shared helper like installShutdownHandlers(httpServer, close) would prevent these copies from diverging.

♻️ Suggested extraction

+ // src/shutdown-handler.ts
+ import type { ClosableHttpServer } from "./server-shutdown.js";
+ import { shutdownHttpServer } from "./server-shutdown.js";
+
+ export function installShutdownHandlers(
+   httpServer: ClosableHttpServer,
+   close: () => Promise<void>,
+ ): void {
+   let shuttingDown = false;
+   const shutdown = async () => {
+     if (shuttingDown) return;
+     shuttingDown = true;
+     await shutdownHttpServer(httpServer, close);
+     process.exit(0);
+   };
+   const handleShutdown = () => {
+     void shutdown().catch((error) => {
+       console.error("devspace shutdown failed", error);
+       process.exit(1);
+     });
+   };
+   process.once("SIGINT", handleShutdown);
+   process.once("SIGTERM", handleShutdown);
+ }

Then in both cli.ts and server.ts:

-  let shuttingDown = false;
-  const shutdown = async () => {
-    if (shuttingDown) return;
-    shuttingDown = true;
-    await shutdownHttpServer(httpServer, close);
-    process.exit(0);
-  };
-  const handleShutdown = () => {
-    void shutdown().catch((error) => {
-      console.error("devspace shutdown failed", error);
-      process.exit(1);
-    });
-  };
-  process.once("SIGINT", handleShutdown);
-  process.once("SIGTERM", handleShutdown);
+  installShutdownHandlers(httpServer, close);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/cli.ts` around lines 232 - 246, Extract the duplicated shutdown flow into
a shared installShutdownHandlers helper, including the shuttingDown guard,
shutdown() cleanup, handleShutdown() error handling, and SIGINT/SIGTERM
process.once registrations. Replace the inline implementations in both cli.ts
and server.ts with calls to this helper, passing httpServer and close while
preserving existing exit behavior.